Update to the Fill Paragraph Patch

The following is a non complete list of updates of the patch that allows you to fill paragraphs with more than one indentation level.

May 27, 2006 Pine 4.64

Added code that reduces the number of false positives. That is pine would detect a quote string where there was none. I am still in the process of adding code to Pine to reduce the number of false positives.

April 22, 2006 Pine 4.64

Fixed a bug which made Pine crash when the headers section contains too many lines, and there is special formatting in them. The problem was that there was an array which was accessed but not checked for its length, hence the crash. Reported by Bernhard Kaindl.

February 23, 2006 Pine 4.64

Fixed a bug which made Pine print erroneous characters to the screen when it painted a signature. The bug was triggered by Pine misrecognizing certain control characters as quote characters and painting extra levels of quoting. This bug was found by Radu Cornea, who used this patch in conjunction with the UTF-8 patch. In debugging this problem, Bernhard Kaindl sent me a report explaining how to reproduce this bug and workarounds on how to avoid it, which helped me find the origin of the problem. Thank you.

September 28, 2005 Pine 4.63

Fixed a bug which made Pine crash when opening certain messages. The problem was that Pine was trying to free some memory that normally does not exist (i.e. a variable of the type it was trying to free is never created, hence never freed). In this case, there was a case where the creation of this type of memory happened (hence a bug), which caused the crash. Reported by Ken Scott.

September 23, 2005 Pine 4.63

I have added an improvement to this patch that is related to the last modification. In the last modification I had added code that set a variable to a fixed value. Now this value is computed and set dinamically. It does not change much the code. One of the main changes, however, that this change and the previous one make, is that it makes the algorithm depend on the relationship of 4 consecutive lines.

August 05, 2005 Pine 4.63

There was a problem when one tried to justify text whose processed quote strings were the same, yet their raw quote strings were not, which could make Pico identify incorrectly the beginning and end of paragraphs, which in turn could make Pico "eat text away" from the paragraph when justified.

May 19, 2005 Pine 4.63

There was a crash when Pine was built using gcc 4.0 which caused Pine to crash when copying data. Patched by Robert Delius Royar. (It has been reported by Andreas Fehr that a crash is also possible using gcc 3.4.3).

February 04, 2005 Pine 4.62

Add support for trimming quoted text. Now the variable quote-suppression-threshold also controls the number of consecutive lines that are displayed in quoted text, not only those quoted using the > character.

February 03, 2005 Pine 4.62

Fix a bug which caused a buffer overflow while Pine copied data to a fix length buffer.

January 28, 2005 Pine 4.62

Add new command ^W^P that is used to remove paragraphs.

July 23, 2004 Pine 4.61

Fix a bug which made Pine crash if the text of the message was in enriched text. One of the filters created by this patch was not being applied and a later filter which relied on this did not have access to the correct information which would have been created by this filter, making Pine crash. Reported by Geoff Shang.

July 4, 2004 Pine 4.60

Fix a bug which made Pine crash if the text of a message contained a '\r' character not followed by a '\n' character. This time I decided to rewrite the code that I had added on July 1, so that the fix will be in my part of the code, rather in a part that I don't maintain.

July 1, 2004 Pine 4.60

Fix a bug which made Pine crash if the text of a message contained a '\r' character not followed by a '\n' character. One of the filters in Pine is supposed to fix this, but it did not, making my patch crash, so I've fixed the other filter so that this patch won't crash.

June 1, 2004 Pine 4.60

Now the patch supports justification and display of format=flowed text messages that contain different quote strings than ">". The old problem was that if you read a message that contained strange quote string, Pine would scramble the text, for example if a message contains the quote string "> :)", then Pine will think that the quote string is ">" and will scramble the text when it displays and replies to a message like this. Now Pine will work well for most quote strings.

May 17, 2004 Pine 4.60

The new format=flowed support that Pine inserts quotes '>' in the text when it is unwanted, so I had to switch the code to turn this off in the case that the text is not format flowed. I am trying to decide if this is bug or misfeature, and when I have decided about this, I will report it to the Pine team.

March 01, 2004 Pine 4.58

Fix a bug which could make disappear the last line of a message. This was due to the non processing of the last line of the message when the gf_quote_test filter received the GF_EOD flag.
Enhancements to the algorithm that paints signatures so that it will recognize (and ignore sometimes) quote strings that appear in signatures.

February 06, 2004 Pine 4.58

Fix a bug which made Pine recognize a quote string incorrectly, making it "eat" part of the text when it justified.

August 11, 2003 Pine 4.56

Fix a bug which made Pine recognize a quote string incorrectly, making it "eat" part of the text when it justified.

August 8, 2003 Pine 4.56

Fix a bug which made Pine not paint some lines correctly. This was a huge change. It consists in making a new filter that takes two lines and gives one line at the time to color_a_quote. I think I may have to do the same for color_signature, but we'll leave that for later.

July 22, 2003 Pine 4.56

Fix a bug which made Pine not recognize certain combinations of indent strings and quote strings in the same paragraph.

July 21, 2003 Pine 4.56

Fix a bug which sent bug into an infinite recursive call if there was a string of type qsChar followed by space followed by qsChar. Reported by Vwakes.

May 31, 2003 Pine 4.56

Fix a bug which in coloring of signatures that made text below a signature disappear from the screen (but was still present in the message). Reported by Vwakes. Thanks!.

May 07, 2003 Pine 4.55

Fix a small bug of not recognition of one type of quote string

April 17, 2003 Pine 4.55

There was an error during compilation due to a miscount of the number or arguments during a function call to the function quote_match. Reported by several people.

November 25, 2002 Pine 4.50

There is a bug in "unjustification" of paragraphs in Pine, which affects my patch. I have fixed this bug. Reported by Andreas Fehr.

October 31, 2002 Pine 4.44

Improvement in handling of TABS, now it should handle tabs in the first line of the paragraph. This was tricky. The solution was to return as quote string the quote string of the second line of the paragraph, but then when justifying, only enter the part of the quote string that is common to both the first and second lines, and add the remaining spaces afterwards in the first line. Remaining lines are added correctly by the justification algorithm since the quote string is chosen correctly before we justify (in other words, we only needed to be careful about the way we entered the quote string in the first line and how how we chose the quote string for the paragraph).

October 18, 2002 Pine 4.44

A few enhancements to the patch, in the section that paints quote levels in different colors was made. The algorithm is not perfect, but it can be improved, so if you find any way to improve it, please let me know.

October 06, 2002 Pine 4.44

I added code that will make, for those that use colors, mark different levels of quoting in different colors. There is a very natural distinction between level of quoting and a quote string, I hope that for most messages, the algorithm will not notice the difference. It seems to work very well :).

October 02, 2002 Pine 4.44

Yesterday I rewrote this patch in a way which only handles one quote string, which is what the code in Pine does. I submitted that patch to the Pine-Team, for possible inclusion in a future release of Pine. This allowed me to realize how to remove some code from the original patch, and that's the new update that this patch has.

September 30, 2002 Pine 4.44

A new case when spaces are not handled correctly was found, and corrected. I expect that now all cases of handling spaces have been considered and fixed. The new bugs, however, come from improvements to the patch, not by trying to fix old bugs. What's happening is that I am seeing cases where the patch should work. These cases correspond to very strange indent-strings, and I don't know anyone who would have those indent-strings, but I still believe that Pine should handle them "just in case". In case I find new bugs (these are called "academic bugs", as opposed to "bugs that can be found in real life"), I will keep updating the patch.

September 29, 2002 Pine 4.44

Fixed a bug which made pine not justify correctly (or at all), when the indent string was only composed of spaces.

September 27, 2002 Pine 4.44

Fixed a bug that was caused by incorrect counting of the length of a quote string when the line only contained a quote string and the last character was a special character "~:#*". The solution was to add a condition to test for this case in all of these cases and "return".
Finally added support for strings that contain words of arbitrary length by making a very strict definition of what constitutes a word, and a word in a quote string. I've been testing this code for about 3 months already (since I thought that it was controversial at the time that I developed it), and I haven't had any false negatives nor positives!. Probably this is a good time to release it.

July 23, 2002 Pine 4.44

A first attempt to support indentation of paragraphs that are justified with spaces to its left was added. It works for the most basic cases, we will see if we can add extra support for other types of more complicated indentation, although at this time this is a long time project. I am more interested in finding bugs now.

July 22, 2002 Pine 4.44

I resolved what to do with spaces at the end of indent-strings and Pine now justifies correctly paragraphs whose first line contains a space in the beginning of it, but other lines in the paragraph do not. The last missing feature I am thinking of adding is correct indentation of paragraphs that contain several spaces at the beginning of a line in every line. I'll see how I can do that.

July 12, 2002 Pine 4.44

The patch was added code which makes it support more complex indent strings. Other additions include better documentation, recognition of spaces inside a quote character and first level of indentation is always done right. I am still debating about what to do with the last space in the quote string [Pine code takes the approach of adding it only if it exists for level 1, but I take the approach to add it only if present and remove it only on level one if it does not exist in the indent-string].

February 26, 2002 Pine 4.44

Fix a "bug", which was part of the original design of the fillpara function. The bug made Pico create new lines, when a line contained a word which was too long to be justified. In my opinion Pico should leave the text as it is, but it adds this line. Fixed.

February 11, 2002 Pine 4.44

A bug which made Pine crash occurred when a long line was justified. This bug happened only in Pine (not in Pico). It was due to the fact the the last character of the tested line was not set to '\0'.

February 06, 2002 Pine 4.44

Attempt to fix the same bug as yesterday. If you left only one space in the beginning of a line, then Pine may not have justified correctly, now it will.

February 05, 2002 Pine 4.44

A bug was found which made Pine insert a space at the beginning of a line. This made me rewrite the patch and now it will justify in the same way that Pine used to do, with the only difference being that this patch will recognize more quotes than what Pine does. Reported by Lenz Grimmer.
The last fix introduced small new bugs, which were fixed (like the fact that a line beginning in empty spaces may no indent correctly the line following it)

November 22, 2001 Pine 4.42

Patch updated for version 4.42

November 16, 2001 Pine 4.41

Update patch for version 4.41

October 22, 2001 Pine 4.40

Fix a strange bug that made Pine not recognize some quote strings that should be recognized by the patch. It was a very strange bug (just had to add a parenthesis to make it work(!?))

Sept 06, 2001 Pine 4.40

Update the patch for version 4.40 (not released yet)

June 26, 2001 Pine 4.33

Fixed a bug which did not make Pine fill paragraphs correctly in the first line of a paragraph (qlen was added twice in if (ftime){ } part of the code).

June 25, 2001 Pine 4.33

Fixed a bug which did not allow it to handle TABs (as opposed to SPACEs) correctly.

May 28, 2001 Pine 4.33

The cline (current line) variable was not initialized, when it should be initialized as 0. Problem reported by George N. White III (WhiteG@dfo-mpo.gc.ca).

May 25, 2001 Pine 4.33

Patch Released.

May 27, 2006	Pine 4.64
Added code that reduces the number of false positives. That is pine would detect a quote string where there was none. I am still in the process of adding code to Pine to reduce the number of false positives.
April 22, 2006	Pine 4.64
Fixed a bug which made Pine crash when the headers section contains too many lines, and there is special formatting in them. The problem was that there was an array which was accessed but not checked for its length, hence the crash. Reported by Bernhard Kaindl.
February 23, 2006	Pine 4.64
Fixed a bug which made Pine print erroneous characters to the screen when it painted a signature. The bug was triggered by Pine misrecognizing certain control characters as quote characters and painting extra levels of quoting. This bug was found by Radu Cornea, who used this patch in conjunction with the UTF-8 patch. In debugging this problem, Bernhard Kaindl sent me a report explaining how to reproduce this bug and workarounds on how to avoid it, which helped me find the origin of the problem. Thank you.
September 28, 2005	Pine 4.63
Fixed a bug which made Pine crash when opening certain messages. The problem was that Pine was trying to free some memory that normally does not exist (i.e. a variable of the type it was trying to free is never created, hence never freed). In this case, there was a case where the creation of this type of memory happened (hence a bug), which caused the crash. Reported by Ken Scott.
September 23, 2005	Pine 4.63
I have added an improvement to this patch that is related to the last modification. In the last modification I had added code that set a variable to a fixed value. Now this value is computed and set dinamically. It does not change much the code. One of the main changes, however, that this change and the previous one make, is that it makes the algorithm depend on the relationship of 4 consecutive lines.
August 05, 2005	Pine 4.63
There was a problem when one tried to justify text whose processed quote strings were the same, yet their raw quote strings were not, which could make Pico identify incorrectly the beginning and end of paragraphs, which in turn could make Pico "eat text away" from the paragraph when justified.
May 19, 2005	Pine 4.63
There was a crash when Pine was built using gcc 4.0 which caused Pine to crash when copying data. Patched by Robert Delius Royar. (It has been reported by Andreas Fehr that a crash is also possible using gcc 3.4.3).
February 04, 2005	Pine 4.62
Add support for trimming quoted text. Now the variable quote-suppression-threshold also controls the number of consecutive lines that are displayed in quoted text, not only those quoted using the > character.
February 03, 2005	Pine 4.62
Fix a bug which caused a buffer overflow while Pine copied data to a fix length buffer.
January 28, 2005	Pine 4.62
Add new command ^W^P that is used to remove paragraphs.
July 23, 2004	Pine 4.61
Fix a bug which made Pine crash if the text of the message was in enriched text. One of the filters created by this patch was not being applied and a later filter which relied on this did not have access to the correct information which would have been created by this filter, making Pine crash. Reported by Geoff Shang.
July 4, 2004	Pine 4.60
Fix a bug which made Pine crash if the text of a message contained a '\r' character not followed by a '\n' character. This time I decided to rewrite the code that I had added on July 1, so that the fix will be in my part of the code, rather in a part that I don't maintain.
July 1, 2004	Pine 4.60
Fix a bug which made Pine crash if the text of a message contained a '\r' character not followed by a '\n' character. One of the filters in Pine is supposed to fix this, but it did not, making my patch crash, so I've fixed the other filter so that this patch won't crash.
June 1, 2004	Pine 4.60
Now the patch supports justification and display of format=flowed text messages that contain different quote strings than ">". The old problem was that if you read a message that contained strange quote string, Pine would scramble the text, for example if a message contains the quote string "> :)", then Pine will think that the quote string is ">" and will scramble the text when it displays and replies to a message like this. Now Pine will work well for most quote strings.
May 17, 2004	Pine 4.60
The new format=flowed support that Pine inserts quotes '>' in the text when it is unwanted, so I had to switch the code to turn this off in the case that the text is not format flowed. I am trying to decide if this is bug or misfeature, and when I have decided about this, I will report it to the Pine team.
March 01, 2004	Pine 4.58
Fix a bug which could make disappear the last line of a message. This was due to the non processing of the last line of the message when the gf_quote_test filter received the GF_EOD flag. Enhancements to the algorithm that paints signatures so that it will recognize (and ignore sometimes) quote strings that appear in signatures.
February 06, 2004	Pine 4.58
Fix a bug which made Pine recognize a quote string incorrectly, making it "eat" part of the text when it justified.
August 11, 2003	Pine 4.56
Fix a bug which made Pine recognize a quote string incorrectly, making it "eat" part of the text when it justified.
August 8, 2003	Pine 4.56
Fix a bug which made Pine not paint some lines correctly. This was a huge change. It consists in making a new filter that takes two lines and gives one line at the time to color_a_quote. I think I may have to do the same for color_signature, but we'll leave that for later.
July 22, 2003	Pine 4.56
Fix a bug which made Pine not recognize certain combinations of indent strings and quote strings in the same paragraph.
July 21, 2003	Pine 4.56
Fix a bug which sent bug into an infinite recursive call if there was a string of type qsChar followed by space followed by qsChar. Reported by Vwakes.
May 31, 2003	Pine 4.56
Fix a bug which in coloring of signatures that made text below a signature disappear from the screen (but was still present in the message). Reported by Vwakes. Thanks!.
May 07, 2003	Pine 4.55
Fix a small bug of not recognition of one type of quote string
April 17, 2003	Pine 4.55
There was an error during compilation due to a miscount of the number or arguments during a function call to the function quote_match. Reported by several people.
November 25, 2002	Pine 4.50
There is a bug in "unjustification" of paragraphs in Pine, which affects my patch. I have fixed this bug. Reported by Andreas Fehr.
October 31, 2002	Pine 4.44
Improvement in handling of TABS, now it should handle tabs in the first line of the paragraph. This was tricky. The solution was to return as quote string the quote string of the second line of the paragraph, but then when justifying, only enter the part of the quote string that is common to both the first and second lines, and add the remaining spaces afterwards in the first line. Remaining lines are added correctly by the justification algorithm since the quote string is chosen correctly before we justify (in other words, we only needed to be careful about the way we entered the quote string in the first line and how how we chose the quote string for the paragraph).
October 18, 2002	Pine 4.44
A few enhancements to the patch, in the section that paints quote levels in different colors was made. The algorithm is not perfect, but it can be improved, so if you find any way to improve it, please let me know.
October 06, 2002	Pine 4.44
I added code that will make, for those that use colors, mark different levels of quoting in different colors. There is a very natural distinction between level of quoting and a quote string, I hope that for most messages, the algorithm will not notice the difference. It seems to work very well :).
October 02, 2002	Pine 4.44
Yesterday I rewrote this patch in a way which only handles one quote string, which is what the code in Pine does. I submitted that patch to the Pine-Team, for possible inclusion in a future release of Pine. This allowed me to realize how to remove some code from the original patch, and that's the new update that this patch has.
September 30, 2002	Pine 4.44
A new case when spaces are not handled correctly was found, and corrected. I expect that now all cases of handling spaces have been considered and fixed. The new bugs, however, come from improvements to the patch, not by trying to fix old bugs. What's happening is that I am seeing cases where the patch should work. These cases correspond to very strange indent-strings, and I don't know anyone who would have those indent-strings, but I still believe that Pine should handle them "just in case". In case I find new bugs (these are called "academic bugs", as opposed to "bugs that can be found in real life"), I will keep updating the patch.
September 29, 2002	Pine 4.44
Fixed a bug which made pine not justify correctly (or at all), when the indent string was only composed of spaces.
September 27, 2002	Pine 4.44
Fixed a bug that was caused by incorrect counting of the length of a quote string when the line only contained a quote string and the last character was a special character "~:#*". The solution was to add a condition to test for this case in all of these cases and "return". Finally added support for strings that contain words of arbitrary length by making a very strict definition of what constitutes a word, and a word in a quote string. I've been testing this code for about 3 months already (since I thought that it was controversial at the time that I developed it), and I haven't had any false negatives nor positives!. Probably this is a good time to release it.
July 23, 2002	Pine 4.44
A first attempt to support indentation of paragraphs that are justified with spaces to its left was added. It works for the most basic cases, we will see if we can add extra support for other types of more complicated indentation, although at this time this is a long time project. I am more interested in finding bugs now.
July 22, 2002	Pine 4.44
I resolved what to do with spaces at the end of indent-strings and Pine now justifies correctly paragraphs whose first line contains a space in the beginning of it, but other lines in the paragraph do not. The last missing feature I am thinking of adding is correct indentation of paragraphs that contain several spaces at the beginning of a line in every line. I'll see how I can do that.
July 12, 2002	Pine 4.44
The patch was added code which makes it support more complex indent strings. Other additions include better documentation, recognition of spaces inside a quote character and first level of indentation is always done right. I am still debating about what to do with the last space in the quote string [Pine code takes the approach of adding it only if it exists for level 1, but I take the approach to add it only if present and remove it only on level one if it does not exist in the indent-string].
February 26, 2002	Pine 4.44
Fix a "bug", which was part of the original design of the fillpara function. The bug made Pico create new lines, when a line contained a word which was too long to be justified. In my opinion Pico should leave the text as it is, but it adds this line. Fixed.
February 11, 2002	Pine 4.44
A bug which made Pine crash occurred when a long line was justified. This bug happened only in Pine (not in Pico). It was due to the fact the the last character of the tested line was not set to '\0'.
February 06, 2002	Pine 4.44
Attempt to fix the same bug as yesterday. If you left only one space in the beginning of a line, then Pine may not have justified correctly, now it will.
February 05, 2002	Pine 4.44
A bug was found which made Pine insert a space at the beginning of a line. This made me rewrite the patch and now it will justify in the same way that Pine used to do, with the only difference being that this patch will recognize more quotes than what Pine does. Reported by Lenz Grimmer. The last fix introduced small new bugs, which were fixed (like the fact that a line beginning in empty spaces may no indent correctly the line following it)
November 22, 2001	Pine 4.42
Patch updated for version 4.42
November 16, 2001	Pine 4.41
Update patch for version 4.41
October 22, 2001	Pine 4.40
Fix a strange bug that made Pine not recognize some quote strings that should be recognized by the patch. It was a very strange bug (just had to add a parenthesis to make it work(!?))
Sept 06, 2001	Pine 4.40
Update the patch for version 4.40 (not released yet)
June 26, 2001	Pine 4.33
Fixed a bug which did not make Pine fill paragraphs correctly in the first line of a paragraph (qlen was added twice in if (ftime){ } part of the code).
June 25, 2001	Pine 4.33
Fixed a bug which did not allow it to handle TABs (as opposed to SPACEs) correctly.
May 28, 2001	Pine 4.33
The cline (current line) variable was not initialized, when it should be initialized as 0. Problem reported by George N. White III (WhiteG@dfo-mpo.gc.ca).
May 25, 2001	Pine 4.33
Patch Released.